-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuadrant reconciling #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Not needed anymore, manifests created within the operator merged api
* Removing unnecessary kuadrant-controller manifest checks * Fixing gateway sample to istio gw * Adding dependency yaml files for local env setup
eguzki
requested changes
Oct 13, 2022
* Config file options were not applied
eguzki
approved these changes
Oct 18, 2022
didierofrivia
pushed a commit
that referenced
this pull request
Nov 8, 2022
The destination hosts to which traffic is being sent should be first class attr in the spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one that brings the reconciling process for RateLimitPolicies and AuthPolicies. It also includes the necessary make targets for dev testing and many fixes to it's API and config.
Verification Steps
kubectl port-forward -n istio-system service/istio-ingressgateway 8080:80 &
curl -v -H 'Host: api.toystore.com' http://localhost:8080/toy
It should return a
200
429
. It may take a while until the policy is applied.