Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dns policy to have immutable strategy field #498

Merged
merged 1 commit into from
Mar 20, 2024
Merged

update dns policy to have immutable strategy field #498

merged 1 commit into from
Mar 20, 2024

Conversation

maleck13
Copy link
Collaborator

What

Makes the routingStrategy immutable. This make migrating between strategies more predictable and sane and also supports the distributd dns work

@maleck13 maleck13 requested a review from a team as a code owner March 20, 2024 12:17
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #498 (fcfeb88) into main (ece13e8) will increase coverage by 0.35%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   80.20%   80.56%   +0.35%     
==========================================
  Files          64       64              
  Lines        4492     4492              
==========================================
+ Hits         3603     3619      +16     
+ Misses        600      589      -11     
+ Partials      289      284       -5     
Flag Coverage Δ
integration 71.66% <ø> (+0.37%) ⬆️
unit 30.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 91.42% <ø> (ø)
pkg/common (u) 88.82% <ø> (ø)
pkg/istio (u) 73.91% <ø> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 64.04% <ø> (ø)
pkg/rlptools (u) 79.45% <ø> (ø)
controllers (i) 77.44% <ø> (+0.64%) ⬆️
Files Coverage Δ
api/v1alpha1/dnspolicy_types.go 81.81% <ø> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, but nothing that need block a merge.

You need to run make bundle though.

@maleck13
Copy link
Collaborator Author

updated

@maleck13 maleck13 merged commit bdb99cd into main Mar 20, 2024
21 checks passed
@eguzki eguzki deleted the gh-450 branch June 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants