GH-641 enforced condition on dnspolicy #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymvavilov
force-pushed
the
GH-641
branch
3 times, most recently
from
0192ff9 to
8f0ce54
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
===========================================
- Coverage 81.21% 29.92% -51.29%
===========================================
Files 64 58 -6
Lines 4492 4147 -345
===========================================
- Hits 3648 1241 -2407
- Misses 569 2837 +2268
+ Partials 275 69 -206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
maksymvavilov
changed the title
|
Changes look good to me |
maleck13
approved these changes
Mar 22, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Following recent changes with the auth policy and introducing DNS Policy to the
enforcedcondition.Also closes #454
How
The policy is used to create DNS Records and records are left with the controller owner annotation that mentions the policy. Listing DNS records and finding the one controlled by the policy should be sufficient to indicate that the policy was enforced, also including a tinny change to the test suite to reflect new logic.
Verification
Integration suite passing should be sufficient. One could go through the "typical installation" and observe policy getting
enforcedstatus.