Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scheduled build naming #407

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Change scheduled build naming #407

merged 1 commit into from
Feb 16, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jan 29, 2024

Summary

This PR aims to solve these two issues:

  • Since the scheduled build actions effectively became nightly builds, update the naming to make it more apparent in both tags and Action name
  • If the kuadrant-operator did not change between builds, but components did, the tag would stay the same but the contents would change
    • This will cause more tags in the quay (literally for each day)

I still need to do a bit of testing to make sure the change is correct but the idea stands and I would like to know your opinion

@adam-cattermole
Copy link
Member

Just a thought based off your comment (not within scope for this PR):

This will cause more tags in the quay (literally for each day)

I wonder whether we want to look into using the LABEL quay.expires.after= again, in particular for Nightly builds to only keep the tags for a certain period of time.

@pehala
Copy link
Contributor Author

pehala commented Jan 29, 2024

I wonder whether we want to look into using the LABEL quay.expires.after= again, in particular for Nightly builds to only keep the tags for a certain period of time.

I think that is a great idea

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #407 (9377959) into main (2c2d5dc) will decrease coverage by 0.90%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   66.59%   65.70%   -0.90%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2598     2563      -35     
- Misses       1120     1147      +27     
- Partials      183      191       +8     
Flag Coverage Δ
integration 70.31% <ø> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.31% <ø> (-1.73%) ⬇️

see 9 files with indirect coverage changes

@pehala pehala marked this pull request as ready for review February 1, 2024 10:11
@pehala pehala requested a review from a team as a code owner February 1, 2024 10:11
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep in mind we could have several different named builds but with the exact same dependencies... maybe we could optimize in the future.

🥟

@pehala pehala merged commit de5b0b8 into Kuadrant:main Feb 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants