Dry-run resource update before comparing changes #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring existing vs desired state of resources when reconciling updates, by dry-running the updates before
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 65.31% 65.24% -0.07%
==========================================
Files 35 35
Lines 3800 3804 +4
==========================================
Hits 2482 2482
- Misses 1125 1128 +3
- Partials 193 194 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
didierofrivia
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
As commented in kubernetes-sigs/kubebuilder#592 (comment), seems to be the agreed way to compare resource objects to date.
alexsnaps
approved these changes
Dec 4, 2023
maleck13
pushed a commit
to maleck13/kuadrant-operator
that referenced
this pull request
Dec 12, 2023
…ring existing vs desired state of resources when reconciling updates, by dry-running the updates before (Kuadrant#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure defaults and all resource mutation are considered before comparing existing vs desired state of resources when reconciling updates, by dry-running the updates before
Closes #354