Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing unit test #344

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Include missing unit test #344

merged 1 commit into from
Dec 4, 2023

Conversation

Boomatang
Copy link
Contributor

@Boomatang Boomatang commented Nov 28, 2023

The controllers directory was not included in the make test-unit, this PR fixes that and the broken unit tests.

Verification

  • all tests should pass.
  • the fixed tests should be included in the the test run. Check this by running make test-unit | grep QueryParamMatchRegularExpression

- include controller directory for unit tests
- fix broken unit tests in controller directory
@Boomatang Boomatang requested a review from a team as a code owner November 28, 2023 16:59
@Boomatang Boomatang self-assigned this Nov 28, 2023
@Boomatang Boomatang added kind/bug Something isn't working size/small area/tests Changes to tests only labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #344 (53faaa3) into main (b736a7b) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   65.18%   65.07%   -0.11%     
==========================================
  Files          35       35              
  Lines        3800     3800              
==========================================
- Hits         2477     2473       -4     
- Misses       1128     1131       +3     
- Partials      195      196       +1     
Flag Coverage Δ
integration 70.08% <ø> (-0.20%) ⬇️
unit 59.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.33% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.08% <ø> (-0.20%) ⬇️

see 5 files with indirect coverage changes

@Boomatang
Copy link
Contributor Author

@guicassolato It would be good to get you to confirm the fixes to the PatternExpression in the unit tests is correct. Some . have being replaced by | and I am not sure if this is the correct behaviour.

@Boomatang Boomatang removed their assignment Dec 4, 2023
@Boomatang Boomatang merged commit 2acf31b into main Dec 4, 2023
18 checks passed
@alexsnaps alexsnaps added this to the v0.6.0 milestone Dec 8, 2023
maleck13 pushed a commit to maleck13/kuadrant-operator that referenced this pull request Dec 12, 2023
- include controller directory for unit tests
- fix broken unit tests in controller directory
@eguzki eguzki deleted the fix/unit_test branch December 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Changes to tests only kind/bug Something isn't working size/small
Projects
Archived in project
Status: To test
Development

Successfully merging this pull request may close these issues.

3 participants