Generate bundle #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make bundle make bundle-build
eguzki
reviewed
Dec 16, 2021
|
|
||
| # BUNDLE_IMG defines the image:tag used for the bundle. | ||
| # You can use it as an arg. (E.g make bundle-build BUNDLE_IMG=<some-registry>/<project-name-bundle>:<tag>) | ||
| BUNDLE_IMG ?= $(IMAGE_TAG_BASE)-bundle:v$(VERSION) | ||
|
|
||
| # Image URL to use all building/pushing image targets | ||
| IMG ?= controller:latest | ||
| IMG ?= quay.io/kuadrant/kuadrant-operator:latest |
There was a problem hiding this comment.
kuadrant org in quay.io 👏 :)
eguzki
reviewed
Dec 16, 2021
| mediatype: "" | ||
| install: | ||
| spec: | ||
| deployments: null |
There was a problem hiding this comment.
👀
we have a operator package that does not deploy anything :) (step by step I know)
There was a problem hiding this comment.
That's just the kustomize base file, the generated CSV has a deployment https://github.com/Kuadrant/kuadrant-operator/pull/3/files#diff-2448a10ce1acbcd0da21db3f6da11959d0dc5897b2319efec8472b69dc5accb0R78
But this operator does do absolutely nothing yet, mainly want this now to add the CI builds.
eguzki
approved these changes
Dec 16, 2021
adam-cattermole
added a commit
to adam-cattermole/kuadrant-operator
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update IMG and IMAGE_TAG_BASE in Makefile (quay.io/kuadrant/kuadrant-operator)
First part of a few smaller PRs to add installation of dependency operators (authorino, limitador, controller)
This is all generated via
make bundle