Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: api machinary #251

Closed
wants to merge 15 commits into from
Closed

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Sep 8, 2023

Based on top of #246

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #251 (a9650b9) into main (f82291d) will decrease coverage by 1.45%.
The diff coverage is 72.94%.

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   64.20%   62.75%   -1.45%     
==========================================
  Files          33       44      +11     
  Lines        3204     3235      +31     
==========================================
- Hits         2057     2030      -27     
- Misses        981     1037      +56     
- Partials      166      168       +2     
Flag Coverage Δ
integration 67.74% <98.57%> (-3.47%) ⬇️
unit 58.34% <68.76%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 74.15% <47.36%> (-1.76%) ⬇️
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 38.38% <ø> (+4.69%) ⬆️
pkg/rlptools (u) 57.63% <ø> (ø)
controllers (i) 67.74% <98.57%> (-3.47%) ⬇️
Files Coverage Δ
api/v1beta2/route_selectors.go 100.00% <100.00%> (ø)
controllers/authpolicy_auth_config.go 80.43% <100.00%> (+4.39%) ⬆️
...ntrollers/authpolicy_istio_authorization_policy.go 62.25% <100.00%> (-0.91%) ⬇️
...ollers/limitador_cluster_envoyfilter_controller.go 79.79% <100.00%> (-3.04%) ⬇️
controllers/ratelimitpolicy_controller.go 62.50% <100.00%> (-11.39%) ⬇️
controllers/ratelimitpolicy_limits.go 68.49% <100.00%> (-4.11%) ⬇️
controllers/ratelimitpolicy_wasm_plugins.go 78.02% <100.00%> (+0.24%) ⬆️
pkg/common/common.go 93.18% <100.00%> (+4.78%) ⬆️
pkg/common/k8s_utils.go 96.55% <ø> (-0.23%) ⬇️
pkg/library/common/domains.go 100.00% <100.00%> (ø)
... and 20 more

... and 3 files with indirect coverage changes

@KevFan KevFan force-pushed the api-machinary branch 3 times, most recently from 0c70a9c to bf4dcb6 Compare September 19, 2023 10:55
@KevFan KevFan force-pushed the api-machinary branch 7 times, most recently from 3afbc68 to 1385b9d Compare October 4, 2023 08:06
@alexsnaps alexsnaps assigned eguzki and KevFan and unassigned eguzki Dec 8, 2023
@alexsnaps alexsnaps added this to the v0.7.0 milestone Dec 18, 2023
@KevFan
Copy link
Contributor Author

KevFan commented Jan 15, 2024

Closing this and re-making a new PR instead on rebasing

@KevFan KevFan closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants