Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace superseded protobuf package #231

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Replace superseded protobuf package #231

merged 1 commit into from
Aug 24, 2023

Conversation

grzpiotrowski
Copy link
Contributor

  • Replaced the deprecated protobuf package

The superseded package is still indirectly referenced by istio.io/api

Resolves #226

Signed-off-by: Grzegorz Piotrowski <[email protected]>
@grzpiotrowski grzpiotrowski requested a review from a team as a code owner August 22, 2023 09:45
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #231 (f1f3f02) into main (0adfe0c) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   64.01%   63.86%   -0.16%     
==========================================
  Files          33       33              
  Lines        3224     3224              
==========================================
- Hits         2064     2059       -5     
- Misses        990      993       +3     
- Partials      170      172       +2     
Flag Coverage Δ
integration 69.85% <ø> (-0.33%) ⬇️
unit 58.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.99% <ø> (ø)
pkg/istio (u) 29.69% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 57.63% <ø> (ø)
controllers (i) 69.85% <ø> (-0.33%) ⬇️
Files Changed Coverage Δ
pkg/rlptools/wasm_utils.go 62.81% <ø> (ø)

... and 3 files with indirect coverage changes

@eguzki eguzki merged commit 6f3b3fd into main Aug 24, 2023
19 of 20 checks passed
@eguzki eguzki deleted the fix-dep-protobuf branch August 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dep: remove usage of github.com/golang/protobuf
2 participants