Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: pin yq version to v4.34.2 #229

Merged
merged 1 commit into from
Aug 14, 2023
Merged

workflow: pin yq version to v4.34.2 #229

merged 1 commit into from
Aug 14, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Aug 11, 2023

@KevFan KevFan requested a review from a team as a code owner August 11, 2023 15:11
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, all looks good

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #229 (5ef0f31) into main (476e637) will decrease coverage by 1.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   63.68%   62.43%   -1.26%     
==========================================
  Files          33       33              
  Lines        3112     3112              
==========================================
- Hits         1982     1943      -39     
- Misses        956      982      +26     
- Partials      174      187      +13     
Flag Coverage Δ
integration 68.01% <ø> (-2.44%) ⬇️
unit 56.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 26.86% <ø> (ø)
pkg/common (u) 77.27% <ø> (ø)
pkg/istio (u) 29.69% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 40.16% <ø> (ø)
pkg/rlptools (u) 54.47% <ø> (ø)
controllers (i) 68.01% <ø> (-2.44%) ⬇️

see 6 files with indirect coverage changes

@KevFan
Copy link
Contributor Author

KevFan commented Aug 11, 2023

Test Scripts (1.19.x, macos-latest) seems to be failing on something unrelated 🤷

Run make operator-sdk
./utils/install-operator-sdk.sh /Users/runner/work/kuadrant-operator/kuadrant-operator/bin/operator-sdk v1.28.1
Downloading https://github.com/operator-framework/operator-sdk/releases/download/v1.2[8](https://github.com/Kuadrant/kuadrant-operator/actions/runs/5834171677/job/15823139370?pr=229#step:4:9).1/operator-sdk_darwin_amd64
gpg: directory '/Users/runner/.gnupg' created
gpg: keyserver receive failed: No route to host
make: *** [/Users/runner/work/kuadrant-operator/kuadrant-operator/bin/operator-sdk] Error 2

@KevFan
Copy link
Contributor Author

KevFan commented Aug 14, 2023

Re-ran the workflow and the failing task has passed now. Codecov has decreased for some reason but is unrelated to this PR.

Going to merge this anyhow

@KevFan KevFan merged commit 473cb4a into Kuadrant:main Aug 14, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants