[test] Unit-tests for common/k8s_utils.go (part 1 of 3) #190
+231
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
reviewed
May 23, 2023
eguzki
reviewed
May 23, 2023
|
looking good. Left few comments |
- Deleted redundant test-case (#190 (comment)) - Generalized the names of objects to 'Kubernetes object' in test-case names kudos to @guicassolato!
eguzki
approved these changes
May 23, 2023
didierofrivia
pushed a commit
that referenced
this pull request
May 24, 2023
* test: Add unit-tests to ObjectInfo (#167) * refactor: Add comment to ObjectInfo (#167) * test: Add unit-test to ReadAnnotationsFromObject (#167) * refactor: Add comment to ReadAnnotationsFromObject (#167) * test: Add unit-test to TagObjectToDelete (#167) * refactor: Add comment to TagObjectToDelete (#167) * test: Add unit-tests to IsObjectTaggedToDelete (#167) * refactor: Add comment to IsObjectTaggedToDelete (#167) * refactor: run goimporst to pass the code-style check (#167) * refactor: Rename 'Kind' fields according to CamelCase naming convention * refactor: Simplify comment to ObjectInfo (#167) * refactor: Compare maps with DeepEqual instead of looping in TestTagObjectToDelete (#167) * refactor: Clean the tests for ObjectInfo (#167) - Deleted redundant test-case (#190 (comment)) - Generalized the names of objects to 'Kubernetes object' in test-case names kudos to @guicassolato!
didierofrivia
pushed a commit
that referenced
this pull request
May 25, 2023
* test: Add unit-tests to ObjectInfo (#167) * refactor: Add comment to ObjectInfo (#167) * test: Add unit-test to ReadAnnotationsFromObject (#167) * refactor: Add comment to ReadAnnotationsFromObject (#167) * test: Add unit-test to TagObjectToDelete (#167) * refactor: Add comment to TagObjectToDelete (#167) * test: Add unit-tests to IsObjectTaggedToDelete (#167) * refactor: Add comment to IsObjectTaggedToDelete (#167) * refactor: run goimporst to pass the code-style check (#167) * refactor: Rename 'Kind' fields according to CamelCase naming convention * refactor: Simplify comment to ObjectInfo (#167) * refactor: Compare maps with DeepEqual instead of looping in TestTagObjectToDelete (#167) * refactor: Clean the tests for ObjectInfo (#167) - Deleted redundant test-case (#190 (comment)) - Generalized the names of objects to 'Kubernetes object' in test-case names kudos to @guicassolato!
didierofrivia
pushed a commit
that referenced
this pull request
May 31, 2023
* test: Add unit-tests to ObjectInfo (#167) * refactor: Add comment to ObjectInfo (#167) * test: Add unit-test to ReadAnnotationsFromObject (#167) * refactor: Add comment to ReadAnnotationsFromObject (#167) * test: Add unit-test to TagObjectToDelete (#167) * refactor: Add comment to TagObjectToDelete (#167) * test: Add unit-tests to IsObjectTaggedToDelete (#167) * refactor: Add comment to IsObjectTaggedToDelete (#167) * refactor: run goimporst to pass the code-style check (#167) * refactor: Rename 'Kind' fields according to CamelCase naming convention * refactor: Simplify comment to ObjectInfo (#167) * refactor: Compare maps with DeepEqual instead of looping in TestTagObjectToDelete (#167) * refactor: Clean the tests for ObjectInfo (#167) - Deleted redundant test-case (#190 (comment)) - Generalized the names of objects to 'Kubernetes object' in test-case names kudos to @guicassolato!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes code refactorings and the addition of unit tests for multiple functions in common/k8s_utils.go. Comments and unit tests were added to functions:
Note: This is the part 1 of 3 of testing the k8s_utils.go. This pull request only partially closes issue #167, and there may be further updates needed in the future.
Coverage: 71.1%