fix e2e tests: do not use istio-ingressgateway in tests #188
+469
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
force-pushed
the
integration-test-using-custom-gateway
branch
from
6391285
to
2e050f2
Compare
eguzki
force-pushed
the
integration-test-using-custom-gateway
branch
from
b2116fc
to
59c1bb6
Compare
didierofrivia
approved these changes
May 22, 2023
didierofrivia
pushed a commit
that referenced
this pull request
May 24, 2023
* fix e2e tests: do not use istio-ingressgateway in tests * controllers/authpolicy_controller_test.go: additional resource state checks * e2e test: RLP targeting Gateway
didierofrivia
pushed a commit
that referenced
this pull request
May 25, 2023
* fix e2e tests: do not use istio-ingressgateway in tests * controllers/authpolicy_controller_test.go: additional resource state checks * e2e test: RLP targeting Gateway
didierofrivia
pushed a commit
that referenced
this pull request
May 31, 2023
* fix e2e tests: do not use istio-ingressgateway in tests * controllers/authpolicy_controller_test.go: additional resource state checks * e2e test: RLP targeting Gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tests should be reproducible and independent from external factors such as the environment or running order. This PR removes the usage of the shared
istio-ingressgatewayGateway in the namespaceistio-system. The integration tests only work with resources in the temporary namespace created for each test.Additionally, new RLP integration test is added where the policy targets the custom gateway directly