-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule build images with git sha reference #149
Conversation
0a08ffb
to
0a39c68
Compare
678a533
to
a2d427e
Compare
81c6c7e
to
b65c5a4
Compare
* Adding branch names and latest tags accordingly * Using OPERATOR_NAME var instead of literal
* Deciding on semantic version * Reusing function for dependencies
* Passing as input variables in caller workflow * Removing conditionals from build images
b65c5a4
to
8191ab0
Compare
what is the value of the weekly build? |
If one of the dependencies is updated, the kuadrant operator generates a new bundle to update the dependency? |
Do we still build operator bundle with references to latest?? would be good to have them as well. |
@eguzki thanks for the review! in response to your comments:
The weekly build will satisfy the needs of QE of having a "snapshot" of kuadrant operator with every dependency pointing to their sha tag stored at the time.
Current solution doesn't support this behaviour, it relies only on the weekly build with the dependencies version stored in action variables. These vars are updated on a daily job requesting the latest reference (commit sha)
We still add the latest tag when the push event targets the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try this out!
This PR introduces a series of changes that makes it possible to:
make bundle
target the dependencies stored variables already collected.workflow_dispatch
event, so the user can manually trigger the whole bundle build with specific versionsCloses #146
Other PRs that complements this one: