[refactor] GW utils for all types of policies #134
Merged
+771
−390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
changed the title
guicassolato
force-pushed
the
refactor/gw-utils
branch
from
a0ad7ca
to
ae2c3fd
Compare
…teways renamed as GatewaysMissingPolicyRef, GatewaysWithValidPolicyRef and GatewaysWithInvalidPolicyRef respectively
guicassolato
force-pushed
the
refactor/gw-utils
branch
2 times, most recently
from
7df54dc
to
7688fd1
Compare
guicassolato
force-pushed
the
refactor/gw-utils
branch
2 times, most recently
from
3c843da
to
af8814c
Compare
…yRef and GatewaysWithInvalidPolicyRef
guicassolato
force-pushed
the
refactor/gw-utils
branch
from
af8814c
to
fa82453
Compare
eguzki
approved these changes
Jan 13, 2023
guicassolato
commented
Jan 13, 2023
|
|
||
| gwKeys, err := r.TargetedGatewayKeys(ctx, policy.GetTargetRef(), policy.GetNamespace()) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
I think we should only return an error here if it's other than not found.
There was a problem hiding this comment.
right. On NotFound error, it should return an empty list.
There was a problem hiding this comment.
I'll make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #126.
RateLimitPolicyReconcilerto the baseTargetRefReconcilerNewGateways,SameGatewaysandLeftGateways) andGatewayWrappertype of the Gateway utils topkg/commonGatewayWrappertype asTargetGateway