Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance creation of RateLimitPolicy around missing limits. #1024

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Enhance creation of RateLimitPolicy around missing limits. #1024

merged 3 commits into from
Nov 18, 2024

Commits on Nov 14, 2024

  1. IMPROVE: validation 

    Ensure the user can create a ratelimit policy without at least one limit.

Signed-off-by: Jim Fitzpatrick <[email protected]>
    @Boomatang
    Boomatang committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c11c535 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Integration tests. 

    Add integration tests for the six states that the user can try add invaild limit blocks.
This does not check if the limits are valid only that they are there.

Signed-off-by: Jim Fitzpatrick <[email protected]>
    @Boomatang
    Boomatang committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dea4490 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Fix: grammer 

    Signed-off-by: Jim Fitzpatrick <[email protected]>
    @Boomatang
    Boomatang committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d79a7d0 View commit details
    Browse the repository at this point in the history