Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacements update #165

Merged
merged 2 commits into from
Nov 15, 2024
Merged

replacements update #165

merged 2 commits into from
Nov 15, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Nov 15, 2024

Some additional replacements

Signed-off-by: Jason Madigan <[email protected]>
Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jason Madigan <[email protected]>
@david-martin
Copy link
Contributor

/lgtm
We can revert if the replacements happen dynamically in future.

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bc8a85e into main Nov 15, 2024
5 checks passed
@jasonmadigan jasonmadigan deleted the replacements-update branch November 29, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants