Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These lines aren't converted to list items #113

Closed
leathersole opened this issue Jun 7, 2024 · 3 comments · Fixed by Kuadrant/kuadrant-operator#692
Closed

These lines aren't converted to list items #113

leathersole opened this issue Jun 7, 2024 · 3 comments · Fixed by Kuadrant/kuadrant-operator#692
Assignees

Comments

@leathersole
Copy link

* Authentication (<code>spec.rules.authentication</code>)
* External auth metadata fetching (<code>spec.rules.metadata</code>)
* Authorization (<code>spec.rules.authorization</code>)
* Custom response items (<code>spec.rules.response</code>)
* Callbacks (<code>spec.rules.callbacks</code>)</p>

@leathersole
Copy link
Author

leathersole commented Jun 10, 2024

@thomasmaas @guicassolato Thanks for fixing this issue.
After I compared the doc and auth.md, I found some other line items aren't converted on the doc site (ex. line 4480-, line 4526-, line 4559-). It seems to be due to the fact that GitHub and MkDocs interpret markdown files differently. I'm going to create issues but you might want to review that difference in its entirety.

Similar issues in Rate Limiting Policy:
line 4272-, line 4284-, line 4392-, line 4489-, line 4576-

@thomasmaas
Copy link

thomasmaas commented Jun 11, 2024

Thank you @leathersole for noticing and letting us know.

@guicassolato / @jasonmadigan any chance we can add something like https://github.com/adamb70/mdx-breakless-lists to have MkDocs behave the same as GitHub Markdown conversion (although incorrect I think) when it comes to not needing a white line before a list?

@jasonmadigan
Copy link
Member

jasonmadigan commented Jun 11, 2024

@thomasmaas I spotted this a few weeks ago and meant to take a look at that same plugin. Thanks for the issue @leathersole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants