refactor: controller-runtime v0.16.3 #444
Conversation
| HealthProbeBindAddress: opts.healthProbeAddr, | ||
| LeaderElection: false, | ||
| } | ||
| if opts.watchNamespace != "" { | ||
| baseManagerOptions.Namespace = opts.watchNamespace | ||
| baseManagerOptions.Cache.DefaultNamespaces = map[string]cache.Config{opts.watchNamespace: {}} |
There was a problem hiding this comment.
Interesting. So now we can supporting watching selected namespaces (plural)?
We need to test this with Authorino deployed in both modes (i.e. cluster-wide and namespaced.)
There was a problem hiding this comment.
Interesting. So now we can supporting watching selected namespaces (plural)?
Yeah, it seems the BaseOptions has moved the Namespace option to Cache.Options.DefaultNamespaces 🤔
By default it will watch from all namespaces unless defined in this slice
So it seems possible to support multi namespace via this if we so choose at some point 🤔
We need to test this with Authorino deployed in both modes (i.e. cluster-wide and namespaced.
Agreed 👍
There was a problem hiding this comment.
| return nil, err | ||
| } | ||
| if options.Metrics.BindAddress != "0" { | ||
| options.Metrics.ExtraHandlers = map[string]http.Handler{"/server-metrics": promhttp.Handler()} |
There was a problem hiding this comment.
Defining extra metric handlers looks to have moved to this option instead:
|
Running e2e tests locally using
|
There was a problem hiding this comment.
I've tested a few scenarios and everything looks good. e2e tests also green.
Nice work, @KevFan!
|
Thanks @guicassolato for testing it out ! 👍 |
With Authorino now using Go 1.20 (Kuadrant/authorino-operator#156), we should bump controller runtime to v0.16.3 as Kuadrant Operator has also moved to this version for consistency (Kuadrant/kuadrant-operator#246)