Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend price filter #87

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Conversation

carlos-kryha
Copy link
Contributor

@carlos-kryha carlos-kryha commented Nov 9, 2023

QA surfaced several problems with the price filter components:

  • Slider input is not usable with ranges > ~1000, since the steps are too big to find specific numbers

Fix: removed slider input component, added todo with potential solutions, and adjusted wrapper ui

  • Min/max input components missing value property

Fix: added value property

  • Price metrics affected by price filters

Fix: calculate price metrics using full market instead of filtered

  • Min/max input used uIST, while all prices show IST

Fix: refactor filters to use IST

  • Clear all does not clear price filter

Fix: refactor reset mechanism to work with clear all feature

@carlos-kryha carlos-kryha merged commit 977d822 into develop Nov 10, 2023
@carlos-kryha carlos-kryha deleted the hotfix/frontend-price-filter branch November 10, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants