Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/hair item filter #54

Merged
merged 47 commits into from
Oct 18, 2023
Merged

Hotfix/hair item filter #54

merged 47 commits into from
Oct 18, 2023

Conversation

carlos-kryha
Copy link
Contributor

This enebles us to exclude certain category/rarity combinations from the item shop. Currently excluding legendary hair items due to #53

  • cleaned up item-shop data
  • added const for filtering out by [[Category, Rarity[]]]
  • implemented filters in item-shop
  • update view

Xabier Almazor and others added 30 commits September 26, 2023 15:00
@Pandelissym
Copy link
Contributor

The items dont show up in the shop anymore but you can still see the Market: 3 items thing at the top below the filters (have filtered for hair + legendary in the img below). Think its an easy fix just pass the filteredItems.length instead of the items.length to the component.
image

@carlos-kryha
Copy link
Contributor Author

Good catch, fixed!

@carlos-kryha carlos-kryha self-assigned this Oct 17, 2023
@carlos-kryha carlos-kryha merged commit 44196a4 into develop Oct 18, 2023
@carlos-kryha carlos-kryha deleted the hotfix/hair-item-filter branch October 18, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants