fix PR #358 review findings - #362
Merged
jeremy-wayland merged 1 commit intoSep 16, 2026
Merged
jeremy-wayland merged 1 commit into
jeremy-wayland merged 1 commit into
Conversation
jeremy-wayland
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues identified
scan_root, which dropssrc/,build/etc. on subdirectory scans — relative paths never matchgit_root..../vendor/...causes everything to be ignored.Nonechecker — ignored files get a dirty hash or report false staleness.auto-generated/GENERATED CODEvariants; explicit files are handled inconsistently; subdirectory scans bypass the root.toposignore.Fixes
evaluate, so results stay consistent.-/_/'variants and add missing header triggers; explicit files intentionally bypass ignore rules; load.toposignorefrom both scan root and git root.