Skip to content

fix PR #358 review findings - #362

Merged
jeremy-wayland merged 1 commit into
feat/cli-discovery-path-filteringfrom
fix/cli-discovery-review-findings
Sep 16, 2026
Merged

jeremy-wayland merged 1 commit into
feat/cli-discovery-path-filteringfrom
fix/cli-discovery-review-findings

Conversation

@sgathrid

@sgathrid sgathrid commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

Issues identified

  • Top-level detection uses scan_root, which drops src/, build/ etc. on subdirectory scans — relative paths never match git_root.
  • Builtin checks use absolute path components — a checkout under .../vendor/... causes everything to be ignored.
  • Fingerprint/freshness use a None checker — ignored files get a dirty hash or report false staleness.
  • Header detection misses auto-generated / GENERATED CODE variants; explicit files are handled inconsistently; subdirectory scans bypass the root .toposignore.

Fixes

  • Anchor top-level detection to the git root (single source of truth), falling back to scan root when there's no git repo.
  • Check builtin/topos/git ignores using scan-relative or git-relative paths — no more per-file canonicalization.
  • Fingerprint/freshness now use the same checker as evaluate, so results stay consistent.
  • Normalize -/_/' variants and add missing header triggers; explicit files intentionally bypass ignore rules; load .toposignore from both scan root and git root.

@sgathrid sgathrid self-assigned this Sep 8, 2026
@sgathrid sgathrid added the bug Something isn't working label Sep 8, 2026
@sgathrid sgathrid changed the title fix(discovery): address PR #358 review findings fix PR #358 review findings Sep 8, 2026
@jeremy-wayland
jeremy-wayland merged commit 3812be2 into main Sep 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants