Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken Multiple property #14

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

AlexanderNorup
Copy link
Contributor

Hi. Thanks for making this great package.

I noticed that the Multiple property on OpenFilePickerOptionsStartInWellKnownDirectory and OpenFilePickerOptionsStartInWellKnownDirectory did not work. No matter what the property was set to, it would always just open in "single-file" or "single-directory" mode.
This seemed to be because of an inverted if-check.

I built it locally with the proposed changes, which fixed the issue.

I noticed that the `Multiple` property on `OpenFilePickerOptionsStartInWellKnownDirectory` and `OpenFilePickerOptionsStartInWellKnownDirectory` did not work.
This seemed to be because of an inverted if-check. I built it locally with the proposed changes, which fixed the issue.
@KristofferStrube
Copy link
Owner

KristofferStrube commented Jul 12, 2022

Super nice catch Alexander. 👍

I have tested your fork and it works now.

Could be nice to capture that this now works as there isn't a sample page that opens multiple files.
Would you be up for adding a sample page that uses multiple files as a part of the PR?
Totally okay if you don't have a good example or don't want to, then I will just think of one during the next couple of days.
Could be using this component https://github.com/lzinga/BlazorTextDiff

@AlexanderNorup
Copy link
Contributor Author

Hi again,

I added a simple sample page that demoes opening multiple files. See below:

chrome_2022-07-12_18-40-00.mp4

If you have visions for bigger and more exciting demo pages, I'm sorry to dissapoint.

@KristofferStrube
Copy link
Owner

KristofferStrube commented Jul 12, 2022

Awesome!
I will publish this to Nuget as a bug fix release later tonight.

@KristofferStrube KristofferStrube merged commit 67b4de6 into KristofferStrube:main Jul 12, 2022
@KristofferStrube
Copy link
Owner

Hah. Wrong button. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants