User error: Don't remove the backport label from a PR too soon

[DilumAluthge]

I'm not sure if I've made an error, or if this is a bug in the Backporter script.

Look at this PR (JuliaLang/julia#59521), and in the PR description, look at the edit history, and in particular compare my first edit to my second edit. Here are some screenshots.

My first edit:

My second edit:

In both cases, I have simply copy-pasted the contents from the Backporter script's output.

In my first edit, you can see that #59300 is listed there under "Backported PRs".

In my second edit, for some reason #59300 has been removed from the list. But if you look at the PR commits (https://github.com/JuliaLang/julia/pull/59521/commits), you'll see that #59300 is still backported.

[DilumAluthge]

Ah, okay, so this is definitely user error on my part.

So, yesterday, after I pushed to the backports branch, I ran the backporter script again, and it printed a list of PRs that met both of the following conditions:

1. The PR has the backport 1.11 label.
2. The PR now has a backport commit on the backports-release-1.11 branch.

And the script suggested removing the backport 1.11 label from those PRs. So yesterday I removed the backport 1.11 label from those PRs - this was my error.

So today, when I ran the script again, the backporter script didn't even retrieve any of those PRs (because they no longer had the backport 1.11 label, because I had incorrectly removed it), and thus when the backport script generated the PR description, of course it didn't include those PRs in the list.

I think the answer is that I shouldn't have removed the backport 1.11 label from those PRs.

[KristofferC]

I manually remove the backport label after I have merged the backport PR typically.