-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thermally coupled Constitutive Laws #9053
Thermally coupled Constitutive Laws #9053
Conversation
applications/ConvectionDiffusionApplication/python_scripts/coupled_structural_thermal_solver.py
Outdated
Show resolved
Hide resolved
applications/ConvectionDiffusionApplication/python_scripts/coupled_structural_thermal_solver.py
Outdated
Show resolved
Hide resolved
…pled_structural_thermal_solver.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Se my comment of VariableUtils
This has a small overhead..., I am OK because there is not easy manner. Except maybe templated static auxiliary methods... |
Te other option is to repeat all the code and leave alone the original CL... IDK if more templates.. hehe |
applications/ConvectionDiffusionApplication/python_scripts/coupled_structural_thermal_solver.py
Outdated
Show resolved
Hide resolved
…om/KratosMultiphysics/Kratos into thermal-solver-mechanical-coupling
applications/ConvectionDiffusionApplication/python_scripts/coupled_structural_thermal_solver.py
Outdated
Show resolved
Hide resolved
ok guys! I've done quite an effort in avoiding code repetition. In this case I avoided I've moved a previously repeated method to the utilities to reuse the same implementation. |
It works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing my block
Let's see if @rubenzorrilla @RiccardoRossi @philbucher have something to say |
ping |
Pong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests subsubfolder are still in there. Besides, the subfolder is at the level of the files of another test, something that is way misleading.
Please, either wrap the already existent test files in a new folder or simply put the thermo_mechanical_accessor
at the same level.
done |
ping |
|
Thanks. Now it's much more tidy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my concerns have been addressed. Good job.
@AlejandroCornejo right now |
yeah!!!!!!!!!!!!!!!!!!!!! finally :) |
Description
Dear @KratosMultiphysics/structural-mechanics and @KratosMultiphysics/constitutive-models
I'm implementing all the code infraestructure in order to be able to simulate thermo-mechanical calculations with a solver that couples the
Structural
and theConvectionDiffusion
Apps.The solver was already there long time ago, I've just improved it a bit and corrected a detail.
The setting of the
REFERENCE_TEMPERATURE
, different options are implemented: using theGetValue()
in theGeometry
(has to be set outside by someone) and being a material property as:Changelog
Please summarize the changes in one list to generate the changelog:
E.g.
Documentation
Now, the
materials.json
for the structural problem looks as this: