[GeoMechanicsApplication] Fix ordering issue for reset displacement #12845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7019e6.
… the executeinitialize
rfaasse
changed the title
avdg81
reviewed
Nov 12, 2024
applications/GeoMechanicsApplication/custom_python/add_custom_utilities_to_python.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/python_scripts/geomechanics_analysis.py
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.h
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.h
Outdated
Show resolved
Hide resolved
WPK4FEM
previously approved these changes
Nov 12, 2024
avdg81
previously approved these changes
Nov 13, 2024
avdg81
previously approved these changes
Nov 13, 2024
There were some sonarcloud issues, fixed now 👍 |
WPK4FEM
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We found an ordering issue with the resetting of the displacements, which was done before executing the processes for Dirichlet conditions, such that prescribed displacements were not overwritten. However, for the reset displacement process, we need the displacements of the elements to not have been reset yet. Therefore, we revert the fix made in #11933, but make sure that fixed Dofs are not overwritten to make sure reset displacements and prescribed displacements still work in a single stage.