Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMApp] Element file sorting and foldering #12817

Merged
merged 11 commits into from
Nov 4, 2024

Conversation

AlejandroCornejo
Copy link
Member

@AlejandroCornejo AlejandroCornejo commented Nov 3, 2024

📝 Description
Just creating folders to tidy the element list. Now is clearer and faster to find elements.

Since this change affects the directories of the StructuralMechanics elements, please ensure that your related Apps compile in this PR (commit changes if necessary).

CLApp and ContactSMApp have been updated.

@KratosMultiphysics/geomechanics I did minor updates but in my pc I could not compile your App due to unrelated (IMO) reasons:

/home/alejandro/Kratos/applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_plane_strain_2D_law.cpp:58:1: error: function ‘Kratos::GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(Kratos::GeoLinearElasticPlaneStrain2DLaw&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
   58 | GeoLinearElasticPlaneStrain2DLaw::GeoLinearElasticPlaneStrain2DLaw(GeoLinearElasticPlaneStrain2DLaw&& rOther) noexcept = default;
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/alejandro/Kratos/applications/GeoMechanicsApplication/custom_constitutive/linear_elastic_plane_strain_2D_law.cpp:59:35: error: function ‘Kratos::GeoLinearElasticPlaneStrain2DLaw& Kratos::GeoLinearElasticPlaneStrain2DLaw::operator=(Kratos::GeoLinearElasticPlaneStrain2DLaw&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
   59 | GeoLinearElasticPlaneStrain2DLaw& GeoLinearElasticPlaneStrain2DLaw::operator=(

@loumalouomega @philbucher @sunethwarna @rubenzorrilla @SergioJimenezReyes @ChengshunShang1996

@AlejandroCornejo
Copy link
Member Author

Updated dir:

imagen

@matekelemen
Copy link
Contributor

matekelemen commented Nov 3, 2024

just wondering: why are the move constructor and move assignment operator defined out of line if they're defaulted? Especially since they're also noexcept, I would have imagined that inlining them is the way to go.

@AlejandroCornejo AlejandroCornejo merged commit 38f86d0 into master Nov 4, 2024
11 checks passed
@AlejandroCornejo AlejandroCornejo deleted the cleaning-up-SMApp-elements branch November 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants