[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12340

mnabideltares · 2024-05-03T10:02:06Z

📝 Description
As part of our ongoing development efforts, we need to implement a heat flux boundary condition for our 1D thermal line element in order to accurately simulate heat transfer behavior. Currently, the boundary conditions for this element type are limited to Dirichlet, and the inclusion of a heat flux boundary condition is crucial for modeling scenarios where heat transfer play a significant role. This `boundary is also crucial for wel element which will be implemented in the near future.

🆕 Changelog

Added point heat flux point conditions for 2D and 3D
Fixed a bug related to gradient-shape-functions for 1D element
Added test cases

This is a trick, because winsows does not see difference in small or capital letters, but the compiliation fails on GCC. Delete them first then add them again with small letters

markelov208

Mohamed, very nice. Just a few comments.

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.cpp

applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h

applications/GeoMechanicsApplication/tests/test_transient_thermal.py

WPK4FEM

Hi Mohammed,
See the remarks.
Generally pull requests adress 1 thing, here the element and the condition get mixed.
That may complicate later searches.
Regards, Wijtze Pieter

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.cpp

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.h

applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h

...ment/test_thermal_heat_flux_line_element/test_thermal_point_flux_3D3N/ProjectParameters.json

...ment/test_thermal_heat_flux_line_element/test_thermal_point_flux_3D2N/ProjectParameters.json

applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

applications/GeoMechanicsApplication/geo_mechanics_application_variables.cpp

...ts/test_thermal_element/test_thermal_heat_flux_line_element/Common/MaterialParameters2D.json

applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h

markelov208

Have a nice weekend after this hard work.

rfaasse

This is a very nice and concise PR with a good number of tests! I have some minor suggestions/questions, mainly I think it will be good to add documentation for the new tests.

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.cpp

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.h

applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h

...ts/test_thermal_element/test_thermal_heat_flux_line_element/Common/MaterialParameters2D.json

applications/GeoMechanicsApplication/geo_mechanics_application.cpp

# Conflicts: # applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h # applications/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_line_element/Common/MaterialParameters2D.json # applications/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_line_element/Common/MaterialParameters3D.json

rfaasse

Thank you for implementing the review comments, I just have a few minor suggestions left.

...echanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element/README.md

rfaasse · 2024-05-08T12:33:57Z

applications/GeoMechanicsApplication/tests/test_transient_thermal.py

-        test_name = 'test_thermal_heat_flux_2D3N'
-        file_path = test_helper.get_file_path(os.path.join('test_thermal_element', 'test_thermal_heat_flux', test_name))
+
+    def check_temperature(self, test_directory, test_name, test_node, etalon_value):


To me, from the name it's not directly clear that this function actually runs a simulation before checking results. Do you think we should reflect that in the name?

Indeed, I do agree that the name of the test must reflects exactly what the test is meant for. Do you have suggestion for a more clear name?

We could consider to move the check itself back to the test bodies, and only run the thermal analysis here, which returns a list of temperatures. In the test body, all you need to do extra is get the temperature value at the relevant node (from the returned list of temperatures) and compare it to an expected value. That would reduce the parameter list here (since you no longer need test_node and etalon_value), and it would make it simpler to give this function a proper name, e.g. run_thermal_analysis. Each test then consists of two lines: (1) running the thermal analysis, and (2) comparing the relevant temperature value. What do you think?

applications/GeoMechanicsApplication/tests/test_transient_thermal.py

avdg81

A very nice, clean, and self-containing extension of your thermal analysis tools. I have several suggestions, but all of them are minor in nature. Well done, and thanks for keeping this PR relatively small!

avdg81 · 2024-05-08T11:39:20Z

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.h

Please reformat this file using clang-format.

applications/GeoMechanicsApplication/custom_conditions/thermal_point_flux_condition.h

...echanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element/README.md

...hermal_heat_flux_line_element/test_thermal_point_flux_2D2N/test_thermal_point_flux_2D2N.mdpa

avdg81 · 2024-05-08T13:15:55Z

applications/GeoMechanicsApplication/tests/test_transient_thermal.py

-        test_name = 'test_thermal_heat_flux_2D3N'
-        file_path = test_helper.get_file_path(os.path.join('test_thermal_element', 'test_thermal_heat_flux', test_name))
+
+    def check_temperature(self, test_directory, test_name, test_node, etalon_value):


Perhaps we can combine test_directory and test_name in a single parameter (e.g. tail_of_test_path), since the only thing you do with these two parameters is to combine them into a path.

avdg81 · 2024-05-08T13:22:27Z

applications/GeoMechanicsApplication/tests/test_transient_thermal.py

-        test_name = 'test_thermal_heat_flux_2D3N'
-        file_path = test_helper.get_file_path(os.path.join('test_thermal_element', 'test_thermal_heat_flux', test_name))
+
+    def check_temperature(self, test_directory, test_name, test_node, etalon_value):


We could consider to move the check itself back to the test bodies, and only run the thermal analysis here, which returns a list of temperatures. In the test body, all you need to do extra is get the temperature value at the relevant node (from the returned list of temperatures) and compare it to an expected value. That would reduce the parameter list here (since you no longer need test_node and etalon_value), and it would make it simpler to give this function a proper name, e.g. run_thermal_analysis. Each test then consists of two lines: (1) running the thermal analysis, and (2) comparing the relevant temperature value. What do you think?

WPK4FEM

I think you are very close. Only a remark about the text in the Readme file.

WPK4FEM · 2024-05-08T15:20:58Z

...echanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element/README.md

+**Source files:** [Thermal line element with point flux condition](https://github.com/KratosMultiphysics/Kratos/tree/master/applications/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element)
+
+## Case Specification
+In this thermal test case, a 1 m height soil column is considered, where the initial temperature in the entire domain is set to 0 $\mathrm{[^\circ C]}$. The top boundary condition is set to be 0 $\mathrm{[^\circ C]}$. A heat flux of 100 $\mathrm{[W/m^2]}$ is set at the bottom boundary. The simulation spans 250 days to allow for a transition from an exponential to a linear temperature profile between the two sides. This test is conducted for various configurations, including 2D2N, 2D3N, 2D4N, 2D5N, 3D2N and 3D3N line elements. The temperature distribution along the depth is then evaluated with its own result.


I do not understand the remark: "from and exponential"
the initial situation is a constant zero temperature field.

WPK4FEM · 2024-05-08T15:44:31Z

...echanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element/README.md

+**Source files:** [Thermal line element with point flux condition](https://github.com/KratosMultiphysics/Kratos/tree/master/applications/GeoMechanicsApplication/tests/test_thermal_element/test_thermal_heat_flux_line_element)
+
+## Case Specification
+In this thermal test case, a 1 m high soil column is considered, where the initial temperature in the entire domain is set to 0 $\mathrm{[^\circ C]}$. The top boundary condition is set to be 0 $\mathrm{[^\circ C]}$. A heat flux of 100 $\mathrm{[W/m^2]}$ is set at the bottom boundary. The simulation spans 250 days to allow for a transition from an exponential to a linear temperature profile between the two sides. This test is conducted for various configurations, including 2D2N, 2D3N, 2D4N, 2D5N, 3D2N and 3D3N line elements. The temperature distribution along the depth is then evaluated with its own result.


I do not understand the remark about exponential. It starts from a constant zero temperature field.

WPK4FEM

Good to go.

mnabideltares added 4 commits May 3, 2024 09:23

Added flux point condition for thermal part

9668b1c

deleted thermal files, in order to add them again with small letters

9d603be

This is a trick, because winsows does not see difference in small or capital letters, but the compiliation fails on GCC. Delete them first then add them again with small letters

Added the files again with small letters

b21ee29

Added test cases for 2D and 3D line elements -> 2D and 3D point fluxes

7fbf79d

mnabideltares linked an issue May 3, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12324

Closed

mnabideltares self-assigned this May 3, 2024

mnabideltares added the Feature label May 3, 2024

mnabideltares requested review from avdg81, rfaasse, markelov208 and WPK4FEM May 3, 2024 10:03

A small fix

30bf80f

markelov208 reviewed May 3, 2024

View reviewed changes

mnabideltares added 3 commits May 3, 2024 15:06

Added section area to line element

2683f4b

Fixed test cases which were influenced by adding SECTION_AREA

00c8bf7

Modifications based on review requirements

c62c47f

mnabideltares requested a review from markelov208 May 3, 2024 15:31

WPK4FEM reviewed May 3, 2024

View reviewed changes

markelov208 previously approved these changes May 3, 2024

View reviewed changes

rfaasse reviewed May 6, 2024

View reviewed changes

Modifications based on review

46c005e

mnabideltares dismissed markelov208’s stale review via 46c005e May 6, 2024 13:13

mnabideltares added 5 commits May 6, 2024 16:04

Added test documentation

c4daca2

fix in Readme

ea3e7bf

Removed "SECTION_AREA"from registration

5014be5

Modification in material parameters

fa9060b

mnabideltares requested review from WPK4FEM and rfaasse May 8, 2024 11:25

rfaasse reviewed May 8, 2024

View reviewed changes

Modification in README.md based on review suggestions

f8aa35e

avdg81 reviewed May 8, 2024

View reviewed changes

Modifications based on review

b966c34

WPK4FEM reviewed May 8, 2024

View reviewed changes

mnabideltares added 2 commits May 8, 2024 17:53

fix in README.md

1a51cb6

modifications based on review

555b991

WPK4FEM approved these changes May 8, 2024

View reviewed changes

markelov208 approved these changes May 8, 2024

View reviewed changes

mnabideltares merged commit 44468d2 into master May 9, 2024
11 checks passed

mnabideltares deleted the geo/12324-add-point-thermal-flux branch May 9, 2024 03:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12340

[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12340

mnabideltares commented May 3, 2024

markelov208 left a comment

WPK4FEM left a comment

markelov208 left a comment

rfaasse left a comment

rfaasse left a comment

rfaasse May 8, 2024

mnabideltares May 8, 2024

avdg81 May 8, 2024

avdg81 left a comment

avdg81 May 8, 2024

avdg81 May 8, 2024

avdg81 May 8, 2024

WPK4FEM left a comment

WPK4FEM May 8, 2024

WPK4FEM May 8, 2024

WPK4FEM left a comment

[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12340

[GeoMechanicsApplication] Add point heat flux (source) condition for heat #12340

Conversation

mnabideltares commented May 3, 2024

markelov208 left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment