[SIApp] Add a SI Unit test #12298
Merged
[SIApp] Add a SI Unit test #12298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
reviewed
Apr 19, 2024
| @@ -18,7 +18,7 @@ def test_DamagedSystem(self): | |||
|
|
|||
| data = numpy.loadtxt("auxiliary_files/damaged_problem/measured_data.csv", comments="#", usecols=[0,3,4,5,6], delimiter=",") | |||
| ref_data = numpy.loadtxt("auxiliary_files/damaged_problem/measured_data_ref.csv", comments="#", usecols=[0,3,4,5,6], delimiter=",") | |||
| self.assertMatrixAlmostEqual(data, ref_data, 9) | |||
| self.assertAlmostEqual(numpy.linalg.norm(data - ref_data), 0.0, 9) | |||
There was a problem hiding this comment.
why not use the numpy comparison routines like I showed in the other PR? Then you can check every value explicitly
There was a problem hiding this comment.
I need to get used to that. Good point :)... Now fixed. :)
Igarizza
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As in the title.
This PR also remove some reminiscence of "DigitalTwin" from SIApp.
🆕 Changelog