Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] std::result_of => std::invoke_result #11749

Merged
merged 3 commits into from
Nov 8, 2023
Merged

[Core] std::result_of => std::invoke_result #11749

merged 3 commits into from
Nov 8, 2023

Conversation

matekelemen
Copy link
Contributor

std::result_of is deprecated and replaced by std::invoke_result.

@matekelemen matekelemen added Kratos Core C++ Deprecated FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Nov 2, 2023
@matekelemen matekelemen self-assigned this Nov 2, 2023
@matekelemen matekelemen requested a review from a team as a code owner November 2, 2023 09:03
loumalouomega
loumalouomega previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from my side

@matekelemen matekelemen removed the FastPR This Pr is simple and / or has been already tested and the revision should be fast label Nov 2, 2023
@matekelemen matekelemen marked this pull request as draft November 2, 2023 09:14
RiccardoRossi
RiccardoRossi previously approved these changes Nov 2, 2023
View reviewed changes
@RiccardoRossi
Copy link
Member

ouch, i approved because it looks correct...but it looks like it is not that easy :-D

@matekelemen
Copy link
Contributor Author

I missed the syntax change :/

@matekelemen matekelemen marked this pull request as ready for review November 2, 2023 09:26
@matekelemen matekelemen merged commit 4459026 into master Nov 8, 2023
10 of 11 checks passed
@matekelemen matekelemen deleted the core/c++17 branch November 8, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumalouomega loumalouomega loumalouomega approved these changes

@RiccardoRossi RiccardoRossi RiccardoRossi left review comments

Assignees

@matekelemen matekelemen

Labels
C++ Deprecated Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matekelemen @RiccardoRossi @loumalouomega