-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Updated multiple moving load tests to work and to run #11722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactoring and code duplication reduction, looks a lot cleaner than before! I have a few minor comments/suggestions and one question about the newly added solving strategy.
applications/GeoMechanicsApplication/tests/test_set_multiple_moving_load_process.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_set_multiple_moving_load_process.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_set_multiple_moving_load_process.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_set_multiple_moving_load_process.py
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_set_multiple_moving_load_process.py
Outdated
Show resolved
Hide resolved
Removed unnecessary new lines
Added typo (',') between tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes and improving (and running) this test case!
📝 Description
Updated geomechanics testing to include the running of test set multiple moving loads automatically.
Updated the logic to include changes made to moving loads (structural mechanics)
Reduced duplication and code smells