Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][MPI] Partially adapt CppTestsUtilities for MPI #11716

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This PR adapts to functions in CppTestsUtilities in order to be MPI ready.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters FastPR This Pr is simple and / or has been already tested and the revision should be fast Transition labels Oct 24, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 24, 2023 09:10
@roigcarlo
Copy link
Member

Could you explain a bit why you have made some of the decisions here?

  • Why serial / distributed is different?
  • In parallel, why nodes 1 to 4 are created both in rank 0 and 1 but not in the rest? and why the 5 to 8 are created in rank 1? Does it mean this will only work with world size 2?
  • Why the elements are created in rank 1 and none of them in rank 0 in parallel but in rank 0 in serial?

Maybe an example on how this will be used in parallel would help?

@roigcarlo roigcarlo requested a review from a team October 24, 2023 14:57
@loumalouomega
Copy link
Member Author

Could you explain a bit why you have made some of the decisions here?

* Why serial / distributed is different?

* In parallel, why nodes 1 to 4 are created both in rank 0 and 1 but not in the rest? and why the 5 to 8 are created in rank 1? Does it mean this will only work with world size 2?

* Why the elements are created in rank 1 and none of them in rank 0 in parallel but in rank 0 in serial?

Maybe an example on how this will be used in parallel would help?

It is a synthetic model part I create for certain Cpp tests. I only do 0 partitions when worl size = 1, and 2 partitions otherwise (more partititions would be complicated). Just that. It is used in the same places these methods are used in serial but for MPI tests.

@loumalouomega loumalouomega merged commit 476406d into master Oct 24, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/mpi/extend-cpptest-utilities branch October 24, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters Testing Transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants