[GeoMechanicsApplycation] Settlement API #11701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormedStatesAfterRunning. Removed template argument from TimeLoopExecutor class.
…dded test for running and terminating a loop with a non-converging solver strategy.
…of the time passed. Added a test on end time after N steps.
…ed ). Passed solver strategy to time step executor.
…crementor with a fixed number of cycles per step. Added RunCycle and RunCycleLoop to the time loop executor.
Also added the `explicit` keyword to a single-argument constructor.
Given a prescribed time incrementor that keeps four time increments and a solver strategy that always converges, we expect to get four converged time step end states, where each one just required a single cycle. Also the time values are validated for each time step end state. Furthermore added a helper function to build a converged end state.
Now that the strategy wrapper is a member of the time loop executor, we can set the end time and the time increment in their "global" variables. Internally, this is done via the model part. The reason we set these variables explicitly is that processes may rely on having this information available.
Extended the API of class `StrategyWrapper` such that we can increment the step number and get the step number upon request.
…rapper needed for the time loop executor.
…for restoring to the initial situation of a step to enable cycling of the step.
…entField implemented and unit tests provided.
…anges a test for the TimeStepExecutor and there is a new one for the TimeLoopExecutor.
…ion' into geo/strategy_wrapper_implementation
1. Prefer to use the pre-increment operator rather than the post-increment operator. 2. Made a local variable `const`.
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp
Show resolved
Hide resolved
rfaasse
changed the title
A node that has been created by a model part does not need to be added explicitly to that same model part later on.
avdg81
reviewed
Oct 23, 2023
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/solving_strategy_wrapper.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_dgeosettlement.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_time_stepping.cpp
Outdated
Show resolved
Hide resolved
avdg81
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR ties the components for the Settlement workflow together and fixes several issues. This means stages 1-3 of the test case (see also the added cpp test in this PR) are run successfully with the expected results.
🆕 Changelog