Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Med] minor cleanup in tests #11700

Merged
merged 5 commits into from
Oct 20, 2023
Merged

[Med] minor cleanup in tests #11700

merged 5 commits into from
Oct 20, 2023

Conversation

philbucher
Copy link
Member

  • improve stucturing of med-files
  • delete unused files
  • Improve comparison fct to optionally check SubModelParts

@philbucher philbucher added Cleanup Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Oct 19, 2023
matekelemen
matekelemen requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@matekelemen matekelemen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In applications/MedApplication/custom_utilities/med_testing_utilities.cpp line 237:

CheckModelPartsAreEqual(rModelPart1.GetSubModelPart(r_smp_name), rModelPart1.GetSubModelPart(r_smp_name));

You're checking the subs of rModelPart1 against themselves.

Sorry for the review format, GitHub won't let me comment on code that hasn't been changed. ¯\_(ツ)_/¯

@philbucher philbucher merged commit 3aa25b9 into master Oct 20, 2023
11 checks passed
@philbucher philbucher deleted the med/test-improvements branch October 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matekelemen matekelemen matekelemen approved these changes

@loumalouomega loumalouomega Awaiting requested review from loumalouomega

Assignees
No one assigned
Labels
Applications Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philbucher @matekelemen