[GeoMechanicsApplication] Moved logic of ApplyScalarConstraintsTableProcess to C++
#11669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class used to be defined in a Python module only. Now that we also need it for the custom settlement workflow, we had to port it from Python to C++. Note that the Python interface now uses the new C++ class. Also added a creator for the `ApplyScalarConstraintsTableProcess` to the process factory used by the custom workflow. The factory should now be able to create all kinds of processes that are relevant for settlement analysis.
WPK4FEM
reviewed
Oct 9, 2023
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Show resolved
Hide resolved
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Outdated
Show resolved
Hide resolved
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Outdated
Show resolved
Hide resolved
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Outdated
Show resolved
Hide resolved
rfaasse
previously approved these changes
Oct 9, 2023
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Outdated
Show resolved
Hide resolved
...ications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_processes/apply_scalar_constraints_table_process.h
Show resolved
Hide resolved
- Moved a member function to a more logical place. - Removed a duplicated member function and renamed the remaining one. - Added a helper function to detect whether a table has been attached to a process. - Since the logic was inverted, some statements had to be rearranged.
rfaasse
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This class used to be defined in a Python module only. Now that we also need it for the custom settlement workflow, we had to port it from Python to C++. Note that the Python interface now uses the new C++ class.
Also added a creator for the
ApplyScalarConstraintsTableProcessto the process factory used by the custom workflow. The factory should now be able to create all kinds of processes that are relevant for settlement analysis.