Fix tspan not respecting text-anchor #2043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text-anchor attribute on
tspan
is not respected. It previously worked in v60.1 however the logic for text-anchor was moved into thesvg/__init__.py
file and caused this edge case not be handled, and there were no specific test cases.See example below where text-anchor="middle" doesn't do anything
Tests pass
Replit reproducing bug: https://replit.com/@mlisitsa/Python-Weasyprint
Example: