Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Never type #21

Merged
merged 2 commits into from
Jan 27, 2022
Merged

add Never type #21

merged 2 commits into from
Jan 27, 2022

Conversation

DetachHead
Copy link
Collaborator

@DetachHead DetachHead commented Jan 6, 2022 •
edited
Loading

closes #20

@KotlinIsland KotlinIsland mentioned this pull request Jan 6, 2022
Open
@DetachHead DetachHead force-pushed the never-type branch 2 times, most recently from 5b319fc to eb6f4e1 Compare January 7, 2022 18:32
KotlinIsland
KotlinIsland requested changes Jan 8, 2022
View reviewed changes
basedtyping/__init__.py Outdated Show resolved Hide resolved
tests/test_never_type/test_typetime.py Outdated Show resolved Hide resolved
tests/test_never_type/test_runtime.py Outdated Show resolved Hide resolved
tests/test_never_type/test_runtime.py Outdated Show resolved Hide resolved
basedtyping/__init__.py Outdated Show resolved Hide resolved
@DetachHead DetachHead force-pushed the never-type branch 2 times, most recently from 1db9186 to 76107b6 Compare January 8, 2022 15:34
KotlinIsland
KotlinIsland reviewed Jan 8, 2022
View reviewed changes
tests/test_never_type/test_runtime.py Outdated Show resolved Hide resolved
tests/test_never_type/test_runtime.py Outdated Show resolved Hide resolved
basedtyping/__init__.py Outdated Show resolved Hide resolved
basedtyping/__init__.py Outdated Show resolved Hide resolved
KotlinIsland
KotlinIsland approved these changes Jan 27, 2022
View reviewed changes
Copy link
Owner

@KotlinIsland KotlinIsland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wait for #31, I have some minor things that I'll commit then.

@KotlinIsland KotlinIsland merged commit 4d116fd into master Jan 27, 2022
@KotlinIsland KotlinIsland deleted the never-type branch January 27, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KotlinIsland KotlinIsland KotlinIsland approved these changes

Assignees
No one assigned
Labels
typetime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never type alias for NoReturn
2 participants
@DetachHead @KotlinIsland