Remove @PublishedApi from unwrap to comply with new compiler resriction
#3810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riction In KT-58551 we require all annotations from expect declaration to be present on actual. Currently, `unwrap` is not called from public inline functions. We can safely remove it.
qwwdfsad
added
the
kotlin-merge-blocker
qwwdfsad
approved these changes
Jul 18, 2023
mshishkina
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://youtrack.jetbrains.com/issue/KT-58551 we require all annotations from expect declaration to be present on actual.
unwrapviolates this by having@PublishedApionly on expect.This blocks merge of PR in KT-58551.
Currently,
unwrapis not called from public inline functions.Looks like just removing annotation is a safe fix.