Disable caching on kover artifact tasks #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
reviewed
Jun 18, 2024
| @@ -19,7 +19,6 @@ import javax.inject.* | |||
| * | |||
| * This artifact that will be shared between projects through dependencies for creating merged reports. | |||
| */ | |||
| @CacheableTask | |||
There was a problem hiding this comment.
Let's specify @DisableCachingByDefault instead of @CacheableTask
shanshin
reviewed
Jun 18, 2024
| @@ -19,7 +19,6 @@ import javax.inject.* | |||
| * | |||
| * This artifact that will be shared between projects through dependencies for creating merged reports. | |||
| */ | |||
| @CacheableTask | |||
There was a problem hiding this comment.
Also, please, rerun all tests after this change, e.g. BuildCacheRelocationTests must fall.
Caching should ony be enabled for tasks that do heavy computations and this task does not do so.
remcomokveld
force-pushed
the
artifact-cache-issue-disable-cache
branch
from
5911cf6 to
8ca086b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633
Alternative solution to #636
Caching should only be enabled for tasks that do heavy computations and this task does not do so.
Potentially it would be good to merge both PRs, even if caching is disabled, we should make sure that data that is used to produce an output is declared as an import.