Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native (Apple): Provide integrations with the native datetime #10

Merged
merged 9 commits into from
Jun 16, 2020
Merged

Native (Apple): Provide integrations with the native datetime #10

merged 9 commits into from
Jun 16, 2020

Conversation

dkhalanskyjb
Copy link
Collaborator

No description provided.

@dkhalanskyjb dkhalanskyjb requested a review from ilya-g June 3, 2020 08:28
ilya-g
ilya-g requested changes Jun 11, 2020
View reviewed changes
darwin-integration/nativeMain/src/Converters.kt Show resolved Hide resolved
darwin-integration/nativeMain/src/Converters.kt Outdated Show resolved Hide resolved
darwin-integration/nativeMain/src/Converters.kt Outdated Show resolved Hide resolved
darwin-integration/nativeTest/src/ConvertersTest.kt Outdated Show resolved Hide resolved
darwin-integration/nativeTest/src/ConvertersTest.kt Outdated Show resolved Hide resolved
settings.gradle Show resolved Hide resolved
@ilya-g
Copy link
Member

ilya-g commented Jun 12, 2020

Publishing needs to be set up for the new project. Check the publishing block in the root build.gradle.kts

@dkhalanskyjb
Copy link
Collaborator Author

Publishing needs to be set up for the new project. Check the publishing block in the root build.gradle.kts

Like this?
https://github.com/Kotlin/kotlinx-datetime/pull/10/files#diff-392475fdf2bc320d17762ed97109a121R31

@ilya-g
Copy link
Member

ilya-g commented Jun 15, 2020 •
edited
Loading

Yes, something like this. You can check if it worked by invoking publishToBuildLocal task and then inspecting artifacts in build/maven directory.
It it works, then no obstacles for pushing are left.

@dkhalanskyjb dkhalanskyjb merged commit 6c22ce6 into master Jun 16, 2020
@dkhalanskyjb dkhalanskyjb deleted the darwin-converters branch July 2, 2020 08:49
@ericCHensssssssss ericCHensssssssss mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-g ilya-g ilya-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkhalanskyjb @ilya-g