-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DGP v2 migration guide #3813
DGP v2 migration guide #3813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
But looks like I still have some small remarks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I agree with the remaining comments, so they should be resolved.
I'm keen to get this merged ASAP, so we can keep refining it (which will be easier when I can more easily see the rendered output!), and get early feedback.
I think we missing a migration tip for a popular custom option from Dokka settings: tasks.dokkaHtml{
dokkaSourceSets {
configureEach {
outputDirectory.set(layout.buildDirectory.dir("dokkaDir"))
}
}
} As I understand, the new version is: dokka {
dokkaPublicationDirectory.set(layout.buildDirectory.dir("dokkaDir"))
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for resolving all of the comments!
This PR contains a guide to migrate to Dokka Gradle Plugin v2
5205a98
to
207298c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work! Most of my suggestions are surface-level, but I did offer some thoughts on clearer communication here and there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment for clarification, otherwise, no notes 💪
This PR contains a guide to migrate to Dokka Gradle Plugin v2
KT-70619/