Update DGP opt-in warnings and messages #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
adam-enko
force-pushed
the
adam/feat/KT-70336/update-v2-messages
branch
from
f95679a
to
d7af020
Compare
- Update styling and formatting. - Add specific warning for V2 migrations. - Add link to https://kotl.in/slack in messages. - Remove the ascii border, it did not render correctly on GitHub Windows CI.
adam-enko
force-pushed
the
adam/feat/KT-70336/update-v2-messages
branch
from
d7af020
to
804e2d1
Compare
adam-enko
added
the
runner: Gradle plugin
whyoleg
approved these changes
Sep 25, 2024
dokka-runners/dokka-gradle-plugin/src/main/kotlin/internal/PluginFeaturesService.kt
Show resolved
Hide resolved
dokka-runners/dokka-gradle-plugin/src/main/kotlin/internal/PluginFeaturesService.kt
Show resolved
Hide resolved
dokka-runners/dokka-gradle-plugin/src/testFunctional/kotlin/MigrationMessagesTest.kt
Show resolved
Hide resolved
dkrasnoff
approved these changes
Sep 26, 2024
|
lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example messages
DGP v1 warning
DGP v2 with helpers
DGP v2