Fix and refactor Sample Transformer #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
commented
Aug 2, 2023
| @@ -91,29 +92,41 @@ class DefaultTemplateModelFactory(val context: DokkaContext) : TemplateModelFact | |||
| get() = URI(this).isAbsolute | |||
|
|
|||
| private fun Appendable.resourcesForPage(pathToRoot: String, resources: List<String>): Unit = | |||
| resources.forEach { | |||
| resources.forEach { resource -> | |||
| /** | |||
There was a problem hiding this comment.
The root of the problem was here
...s-kotlin-api/src/main/kotlin/org/jetbrains/kotlin/analysis/kotlin/internal/SampleProvider.kt
Outdated
Show resolved
Hide resolved
...kotlin/org/jetbrains/dokka/analysis/kotlin/descriptors/compiler/impl/KotlinSampleProvider.kt
Show resolved
Hide resolved
...kotlin/org/jetbrains/dokka/analysis/kotlin/descriptors/compiler/impl/KotlinSampleProvider.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/renderers/html/innerTemplating/DefaultTemplateModelFactory.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Vadim.Mishenev <[email protected]>
vmishenev
force-pushed
the
3087-fix-sample-transformer
branch
from
413b348 to
8d18206
Compare
plugins/base/src/main/kotlin/renderers/html/innerTemplating/DefaultTemplateModelFactory.kt
Outdated
Show resolved
Hide resolved
...is-kotlin-api/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/internal/SampleProvider.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Vadim.Mishenev <[email protected]>
Signed-off-by: Vadim.Mishenev <[email protected]> Signed-off-by: Vadim.Mishenev <[email protected]>
vmishenev
force-pushed
the
3087-fix-sample-transformer
branch
from
4075880 to
1004577
Compare
IgnatBeresnev
pushed a commit
that referenced
this pull request
Aug 8, 2023
(cherry picked from commit 2fd8e90)
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, the PR has some refactoring. I am not sure that the page transformer (
SampleTransformer) should be in the analysis plugin.