Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate buildSrc to composite build #2652

Closed
wants to merge 9 commits into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Sep 3, 2022

@IgnatBeresnev IgnatBeresnev added the runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin label Oct 12, 2022
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to get to, I'm learning Gradle from your PRs and had to read up on it :)

Overall looks good and useful, I only have minor comments/questions

build.gradle.kts Show resolved Hide resolved
build-logic/build.gradle.kts Show resolved Hide resolved
@IgnatBeresnev IgnatBeresnev self-requested a review January 31, 2023 22:23
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Jan 31, 2023

Awesome, thanks!

I noticed that #2704 is very related and it should hopefully make the BuildLogic class unnecessary. However, because it has more changes, it'll be more difficult to rebase than this PR, which mostly contains moved classes.

So if you don't mind, let's wait for #2704 to be merged first, and then hopefully it'll be easy for you to rebase onto it and just move all new/old classes without having to deal with line by line merge conflicts

@Goooler
Copy link
Contributor Author

Goooler commented Feb 1, 2023

No problem.

@IgnatBeresnev IgnatBeresnev added infrastructure Everything related to builds tools, CI configurations and project tooling and removed runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin labels Feb 1, 2023
@Goooler
Copy link
Contributor Author

Goooler commented Feb 14, 2023

Maybe we no need this anymore once #2860 is merged, see https://docs.gradle.org/8.0/release-notes.html#improvements-for-buildsrc-builds.

@3flex
Copy link
Contributor

3flex commented Feb 28, 2023

Maybe we no need this anymore

It's still required. None of the improvements in Gradle 8 change the fact that buildSrc changes cause the whole project to become out of date - there's still a warning about this in the latest Gradle docs.

@Goooler
Copy link
Contributor Author

Goooler commented Feb 28, 2023

Yeah, this PR will go on after #2704 merged.

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Mar 7, 2023

#2704 has finally been merged :) Could you please rebase onto master or merge it in? I'll have a look right away

Since we utilize convention plugins, class BuildLogic : Plugin<Project> won't be needed anymore, right?

@Goooler
Copy link
Contributor Author

Goooler commented Mar 9, 2023

Addressed to #2912.

@Goooler Goooler closed this Mar 9, 2023
@Goooler Goooler deleted the composite_build branch March 9, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants