-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate buildSrc to composite build #2652
Conversation
# Conflicts: # build.gradle.kts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long to get to, I'm learning Gradle from your PRs and had to read up on it :)
Overall looks good and useful, I only have minor comments/questions
Awesome, thanks! I noticed that #2704 is very related and it should hopefully make the So if you don't mind, let's wait for #2704 to be merged first, and then hopefully it'll be easy for you to rebase onto it and just move all new/old classes without having to deal with line by line merge conflicts |
No problem. |
Maybe we no need this anymore once #2860 is merged, see https://docs.gradle.org/8.0/release-notes.html#improvements-for-buildsrc-builds. |
It's still required. None of the improvements in Gradle 8 change the fact that buildSrc changes cause the whole project to become out of date - there's still a warning about this in the latest Gradle docs. |
Yeah, this PR will go on after #2704 merged. |
#2704 has finally been merged :) Could you please rebase onto master or merge it in? I'll have a look right away Since we utilize convention plugins, |
Addressed to #2912. |
Ref detekt/detekt#4090
https://docs.gradle.org/7.5.1/userguide/composite_builds.html