Replace package name on cover with "Package-level declarations" #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
Jul 25, 2022
Comment on lines
-195
to
-196
| padding-top: 12px; | ||
| margin-top: 12px; |
There was a problem hiding this comment.
This is not even noticable since there's bottom padding from h1.cover already. Makes the page a little bit more compact and grabs less attention
IgnatBeresnev
commented
Jul 25, 2022
Comment on lines
-553
to
+552
| font-size: 60px; | ||
| line-height: 64px; | ||
| font-size: 52px; | ||
| line-height: 56px; |
There was a problem hiding this comment.
Also barely noticable, makes longer names class/fucntion fit a bit better and doesn't grab as much attention compared to the rest of the page.
Closed
vmishenev
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2576