Add insert.before { } #1517
Merged
Add insert.before { } #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
reviewed
Oct 27, 2025
| public fun <T> InsertClause<T>.before(column: String): DataFrame<T> = | ||
| df.add(this.column).move(this.column).before(column) | ||
|
|
||
| internal fun <T> InsertClause<T>.beforeImpl(columnPath: ColumnPath): DataFrame<T> { |
Collaborator
There was a problem hiding this comment.
It's a DataFrame convention of putting the internal Impl-ementation of API functions under impl/api/<functionName>.kt. I see we missed it for afterImpl, but let's not make it worse with beforeImpl :) Could you move both beforeImpl and afterImpl to impl/api/insert.kt? :)
thanks in advance!
Collaborator
|
The build again fails due to the api dump not being updated. Please follow the contribution guide and make sure |
Jolanrensen
approved these changes
Oct 28, 2025
Collaborator
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #1516
Once move.before {} was implemented, I exploited it to implement insert.before{}
maintaining consistency with insert.after {}.
It comes with a test inspired by insert.after{}'s one