-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore compatibility with Gradle's configuration cache #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of it!
I have a question about mkdirs
and this PR is good to go
group = "other" | ||
description = "Syncs API from build dir to ${targetConfig.apiDir} dir for $projectName" | ||
from(apiBuildDir) | ||
into(apiCheckDir) | ||
dependsOn(apiBuild) | ||
doFirst { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate on why you removed this mkdirs
call?
Does into
documentation guarantees mkdir
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd, as this doesn't seem to violate the configuration cache contract, but it wouldn't work unless I removed it.
In any case, yes, into
will create the required directories. More here: https://docs.gradle.org/current/userguide/working_with_files.html#sec:creating_directories_example
All core Gradle tasks ensure that any output directories they need are created if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks!
At least now we have a proper test coverage for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, thanks for taking care of it!
Any chance we could get a new release cut? Not sure if there's anything else planned for the next version, but I'd really like to get rid of the |
0.11.1 with the fix is published to maven central. Should be available for regular dependencies within an hour |
Fixes #95