-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support public external JS declarations #42
Comments
To add to this, I believe that's the same for |
Binary-compatibility-validator is intended to be used only with JVM targets. There is no public notion of "binary compatibility" in either JS or K/N, so they are not supported |
Please make it clear in the Readme. Kotlin does support other targets than the JVM and it would be nice, if others targets could benefit from a binary validator plugin too, although without a built in notation this would be a challenge, I know... |
Good point, I will update the readme |
@qwwdfsad Nowadays TS declarations can work as a good public ABI for JS. Already generated in some setups, maybe you can consider supporting it in the |
JS is completely of our focus now, we are working on K2 release and stabilization of KMM, so unfortunately I'm neither ready to accept a contribution for that nor to even do my due diligence and see if that's a reasonable addition for the future |
I’ve created a Gradle plugin that adds support for JS APIs to the KotlinX Binary Compatibility Validator.
Compatibility tested with:
See how to use with the JitPack here: Please try to use the plugin. I’d appreciate any feedback. |
Fixes Kotlin/binary-compatibility-validator#42 Kotlin/binary-compatibility-validator#42 (comment) - Based on the generated TS definitions. - Has support for Kotlin/JS non-KMP projects. - Compatible with BCV 0.8+ Initially made for the Fluxo state management framework, now published for general use: https://github.com/fluxo-kt/fluxo See README for the usage instructions: https://github.com/fluxo-kt/fluxo-bcv-js#how-to-use Signed-off-by: Artyom Shendrik <[email protected]>
Currently, the validator does not create .api files or api declarations for public external declarations, which results into not checking the JS declarations, which could be called from library consumer in Kotlin.
The text was updated successfully, but these errors were encountered: