Add converter for discord-formatted timestamps #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdude2002
added
Type: Enhancement
|
Thanks, I'm happy with this addition. It doesn't quite close #85 as I also intended for this support to be added to the duration converters (for the sake of completeness), but this PR can be merged without that if you'd prefer. |
|
How would you expect that to look like? Discord timestamps are, well, timestamps, not durations. |
|
They're not durations, but they do point to a specific point in time - so it'd be a case of getting the delta between "now" and the timestamp as a duration |
|
This looks good overall. Thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85
Not bothering with the other time modules for now