-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less verbose translation logging #70
Comments
Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:
|
Hey, thanks for the issue! I was thinking about this the other day - currently they're debug level messages, which can indeed get annoying. My current plan is to switch them to trace logging. The i18n stuff can't be disabled since it's a core part of the framework - it's relied upon by pretty much everything. The logging is there to let you know about missing translations, indeed - I think setting them to trace level and removing the traceback should be enough though, right? |
This will be done in the latest push, as well as giving an explicit package name to the logger in case you want to change the logging settings yourself - it'll be |
Thanks for the quick response! I didn't even realize that the stacktraces are part of the logging messages! I had been thinking that they are just printed to stdout by the runtime. I think changing the log level to |
Well, like I say, it's already been pushed up. I'll likely get a release out soonish, since Kord's in another snapshot cycle, but we'll see. |
Don't close it yet, it's not in a release yet haha |
I apologize for the confusion; I started writing my response but then I went away and came back later to finish it, and ended up missing your update. |
I'll be getting a release out shortly, so I'm closing this now - keep an eye on the releases section! |
(Version used:
1.4.4-RC3
)Is there a way to just disable the internationalization functionality?
I have just started using Kord Extensions, and I am not interested in using the resource bundles (not at the moment, at least). I just want to be able to provide strings directly.
The (old) documentation mentions that "translations are optional". While this seems to be true (everything works fine), I am still getting an exception thrown for every single
name
anddescription
of a slash command I set up for my bot.I am seeing two
debug
lines in the log statingAnd then a
While this does not affect any functionality as far as I can tell, it is fairly annoying for development, since I am basically getting two full (long) stacktraces thrown into the console for every single slash command I set up, making it hard to read anything else there.
Is this a bug, or something that was simply missed so far? Or is it supposed to be like that?
If it is, how can I disable it?
I can't even just catch the exceptions, as far as I am aware (I've only recently starting migrating from Java to Kotlin), since they happen somewhere in a coroutine, and I am using the provided DSL to set up the slash commands so I can't put a try-catch block there, either, can I?
If there is no resource bundle set up, should the code be trying to find translation keys at all?
Alternatively, is there a switch to just turn off internationalization entirely, if one is not interested in using it? (Or at least during development, until one starts to add translations.)
The text was updated successfully, but these errors were encountered: