Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActionableComponentBuilder's ID customizable #65

Closed
alex5nader opened this issue Aug 3, 2021 · 2 comments
Closed

Make ActionableComponentBuilder's ID customizable #65

alex5nader opened this issue Aug 3, 2021 · 2 comments
Assignees
Labels
Type: Enhancement Improvements to existing features.

Comments

@alex5nader
Copy link

Current Behaviour

Currently, ActionableComponentBuilder's ID is an open val. This means the only way to provide a non-random ID is to subclass and override it, which is very annoying.

Source, for reference:

Preferred Behaviour

If this field were a constructor parameter, with a default value giving the random ID, or if it were var instead of val, providing a non-random value it would be much nicer.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 3, 2021

Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:

  • Most importantly, all issues must adhere to our Code of Conduct. Please give it a quick read if you haven't already.

  • While our team is passionate about the projects we've created here, we're all volunteers. Please don't be offended if it takes time for us to get to your issue - we'll be here as soonas we can be!

  • Please provide as much information as possible when asking a question, reporting a problem, or submitting a feature request. This will help us to address your issue quickly and efficiently. If you forgot to add some information, no worries - feel free to edit the issue and add anything you missed!

    Thanks for contacting us! If you have any further questions, please feel free to join us on Discord in the #dev-kotdis channel (or #kordex-discussion for Kord Extensions projects), or to contact a staff member directly.

@gdude2002 gdude2002 self-assigned this Aug 5, 2021
@gdude2002 gdude2002 added the Type: Enhancement Improvements to existing features. label Aug 5, 2021
@gdude2002
Copy link
Member

Done done. Current snapshot, next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvements to existing features.
Projects
None yet
Development

No branches or pull requests

2 participants